ParserMode setting as enum rather than GetoptMode as bool#690
ParserMode setting as enum rather than GetoptMode as bool#690rmunn wants to merge 2 commits intocommandlineparser:developfrom
Conversation
This allows adding other modes in the future, while maintaining backwards compatibility as long as the default mode isn't changed.
After discussion in PR commandlineparser#684, renamed ParserMode enums to GetoptParserV1 and GetoptParserV2, so as to not communicate the idea that the older mode is in any way obsolete (it will continue to be supported for the foreseeable future).
|
Enum names are now GetoptModeV1 and GetoptModeV2 as per discussion with @moh-hassan (see #684 (comment) and previous comments for background). |
|
@ericnewton76 - Now that there's some motion on the CommandLineParser project again, I'd like to ask you to take a look at this PR. Having At this point, changing the bool to an enum might be a breaking change, but it's a breaking change in a feature that was only just released so right now would be the time to make it. The longer that change waits, the more people will be affected by it. So please take a look at this PR (#690) as soon as you can. Thanks. |
|
Anyone here? Please? @moh-hassan @ericnewton76? |
2 participants
This is b7102d8 with the Legacy name renamed to Classic so as not to suggest that it's obsolete or going away anytime soon. See #684 (comment) for the rationale.